View Single Post
Old 05-25-2009, 08:57 AM   #1392 (permalink)
dcb
needs more cowbell
 
dcb's Avatar
 
Join Date: Feb 2008
Location:
Posts: 5,038

pimp mobile - '81 suzuki gs 250 t
90 day: 96.29 mpg (US)

schnitzel - '01 Volkswagen Golf TDI
90 day: 53.56 mpg (US)
Thanks: 158
Thanked 267 Times in 210 Posts
Quote:
Originally Posted by MazdaMatt View Post
...Do you have your ADC reading and/or filtering happening during interrupts as well, or polled?
If it still looks anything like the svn code:
/trunk/HighVoltageControllerIMPROVED_ECOM.C - Open ReVolt - Trac

everything is done in a timer interrupt, which might be a problem. Could use a lower priority interrupt for updating some of the variables (i.e. temperature). And any variables updated in an interrupt "thread" should be declared volatile.

Paul, did you measure how long that isr takes to complete in worst case?
__________________
WINDMILLS DO NOT WORK THAT WAY!!!
  Reply With Quote