View Single Post
Old 01-14-2017, 04:31 PM   #32 (permalink)
meelis11
EcoModding Apprentice
 
meelis11's Avatar
 
Join Date: Feb 2009
Location: Estonia
Posts: 199

Green frog - '97 Audi A4 Avant 1.9TDI 81kW
Diesel
90 day: 43.1 mpg (US)
Thanks: 19
Thanked 40 Times in 28 Posts
Hi,
I am Meelis, I have planned lately that I publish my GIT repository and/or maybe we can merge our codes. Seems that you are already taking features from my code and implementing them to your version. I dont mind, my plan was to suggest merging anyway


I dont know how much you use my code, but at least you use some of features I added (referencing them "via Meelis11").
I can say that if you implement all features to your code, them maybe I can ditch mine and there is only one code
Your code seem so low level so I am not sure that I can contribute (assembler and low level pure C)

How many mpguino code "forks" are out there that can be downloaded? (different versions from different people) that are worth considering (not just custom features for persons own use)
They should be added to wiki.

Too bad that I cannot test your code right now, because I have run out all atmega328 chips at the moment, only one is in my car, my arduino is chipless
I am checking your source code and reading what features you have implemented - feature list is really inspiring!

Some questions:

1) are you using some kind of repository for version tracking? If not, then please start using GIT (github or bitbucket, I am using https://bitbucket.org)
https://www.sitepoint.com/git-for-beginners/

2) why are you keeping all sourcecode in one file?

3) How do you compile and upload code to mpguino? do I need to compile it using avr-gcc and use programmer and avrdude, or does copy-paste to arduino IDE and upload using arduino work?
At least it seems to compile in arduino IDE, but gives one warning
"WARNING: Category '' in library OneWire is not valid. Setting to 'Uncategorized'"
Like I said, I cannot test uploading (no atmega chips)

keep up good work!
Meelis
__________________
http://mpguino.wiseman.ee/eng - get assembled mpguino from here!
  Reply With Quote
The Following 3 Users Say Thank You to meelis11 For This Useful Post:
josemapiro (01-14-2017), skybolt (05-15-2017), t vago (01-14-2017)