[t vago]

Originally Posted by skybolt

Trying to deploy 20170116 to ATMega with Parallax LCD. Display beeping madly. In setting bit rate to 384 and 96, found the following:
Line 434. What used to read:

#ifndef useSerialLCD
#undef useLCDserialPort0
#undef useLCDserialPort1
#undef useBufferedLCDserialPort
#endif

Now reads:

#ifndef useSerialLCD
#undef useLCDserialPort0
#undef useLCDserialPort1
#endif

This might be good code or depends on operator setting buffered correctly.

Sounds like the Parallax LCD is getting wrong data. If you're setting the Parallax LCD baud rate to 9600 baud, it helps to press in on the el cheapo DIP switches on the back of the Parallax LCD module as you apply power to it. Otherwise, the only acceptable baudrates for the Parallax display are 2400, 9600, and 19200.

As for the other #undef that no longer appears, that's intentional. I realized that a buffered LCD is a buffered LCD, regardless of whether it goes through the serial port or through the legacy 4-bit interface. Since there are different mutually exclusive #defines for either LCD device, I saw no point in also making a distinction between a buffered serial LCD and a buffered legacy 4-bit LCD display.

Originally Posted by skybolt

Can't set any Refill digits to 0. Examples:

Set to 1. Reset to 0, "parameter unchanged," stays at 1.
After 1, set to 9. Parameter saved as 10.
Set to 15. Try and set to 5. "parameter unchanged," stays at 15.
After 15, set to 10. Parameter saved as 25.

It's supposed to do that. Every time somebody enters some value to the Partial Refill stored parameter, that value actually gets added to the stored parameter. It was meant for people who liked to continually do partial refills.

The Partial Refill menu includes an option to set the Partial Refill stored parameter back to zero. Alternately, choosing the Tank Trip Reset option from the Partial Refill menu, also resets this stored parameter back to zero.

As a safety feature, long button presses are assigned to those functions that cause something to be reset, even under a sub-menu. So, when you go to reset the partial fill amount, you have to hold down the button in order to reset it.

Originally Posted by skybolt

Can't do JSON output on 0; compile error:

sketch/main.cpp: In function 'void pushSerial0Character(uint8_t)':
main.cpp:5895: error: expected primary-expression before ')' token
  while ((UCSR0A & ) == 0); // wait until USART0 data buffer is empty
                   ^
exit status 1
expected primary-expression before ')' token

Trying to debug as best I can (or set correct parameters if I've set them incorrectly to generate this error.

JSON output on serial1 does not generate this error.

Oooops, forgot about that - I apparently forgot to include a bit value in that above expression.

Try this:

	while ((UCSR0A & (1 << UDRE0)) == 0); // wait until USART0 data buffer is empty