t vago's MPGuino workspace thread

[t vago]

I noticed last night, as I was testing the re-written calculation routines, that the Screen Editor is again not working correctly. Working on it...

[t vago]

Haven't really gotten to the Screen Edit bug, yet.

However, I did get the re-written calculation routine to work correctly in all modes, and I got rid of some code in the div64() routine that I had incorrectly thought was helping to speed up the divide operation. Core code size is now at 12766 bytes.

[t vago]

Fixed the Screen Edit bug. Changed the guinosig byte to be different from the previous guinosig and guinosigold bytes. Stored a 24-bit signature value at the beginning of EEPROM, that will be different for any combination of bells 'n' whistles in the 1.86tav code. Reworked the display value calculation routine to not recursively call itself for "remaining" items (remaining time, remaining distance). Split out idle/EOC tracking data into their own separate Trip elements. Added automatic trip save for activity timeout, and added separate stored settings to enable normal trip auto-save and idle/EOC trip auto-save data. Added a really simple general EEPROM data viewer. Increased the number of stored trip slots from 6 to 10.

Slot 0: Auto-saved Tank (if selected)
Slot 1: Auto-saved Tank Idle/EOC (if selected)
Slot 2: Auto-saved Current (if selected)
Slot 3: Auto-saved Current Idle/EOC (if selected)
Slot 4: Available
Slot 5: Available
Slot 6: Available
Slot 7: Available
Slot 8: Available
Slot 9: Available

If auto-save is not enabled, or if the code is compiled to not include idle/EOC tracking, then the affected slots become just ordinary trip storage slots. Oh, yah - idle/EOC tracking and datalogging are now configurable bells 'n' whistles, too.

These code changes ought to make it a lot simpler to add my proposed A-B-A analyzer, as well as that other really neat feature that a few others here have coded in - A graphical display of MPG per speed range.

The table below summarizes the current performance specs.

.	Code size	RAM usage	CPU utilization
Original 0.86	17178	1195	45.58%
Bare	12232	1552	2.32%
Configured as 0.86	12508	1376	11.75%
Everything except MAP Correction	17470	1160	4.21%
Everything	18928	1080	4.21%

This is the current list of bells 'n' whistles:

#define trackIdleEOCdata true			// Ability to track engine idling and EOC modes
#define useDataLogging true			// Ability to output 5 basic parameters to a data logger or SD card
#define useBufferedSerial true			// Speed up data logger
#define useCalculatedFuelFactor true		// Ability to calculate that pesky us/gal (or L) factor from easily available published fuel injector data
#define useBufferedLCD true			// Speed up LCD output (probably going to go away)
#define useWindowFilter true			// Smooths out "jumpy" instant FE figures that are caused by modern OBDII engine computers
#define useClock true				// System clock, and means to set it
#define useSavedTrips true			// Ability to save current or tank trips to any one of 10 different trip slots in EEPROM
#define useScreenEditor true			// Ability to change any of 8 existing trip data screens, with 4 configurable figures on each screen
#define useBarGraph true			// Ability to display Prius-like Fuel Economy bar graph
#define useSpiffyBigChars true
#define useChryslerMAPCorrection true		// Ability to perform on-the-fly fuel injector data correction for late-model Chrysler vehicles
#define useEEPROMviewer true			// Ability to directly examine EEPROM

[josemapiro]

I've been testing your code, and I have the same problem with the buttons.
What is the program you use to make the compilation?
I have used the Arduino IDE 1.5.2. Now installed atmel studio 6.1 but the code has many errors, and not premite upload the code, maybe the settings I have in the program, not well.
I have to do more tests to see.

Thank you
José Rodrigues

[AndrzejM]

I've had the same issue, so I just opened code in a notepad then Ctrl-A Ctrl-C and pasted it to Arduino IDE, to the new project. It worked like a charm. Everything works and no trouble during compiling.

[t vago]

Originally Posted by AndrzejM

I've had the same issue, so I just opened code in a notepad then Ctrl-A Ctrl-C and pasted it to Arduino IDE, to the new project. It worked like a charm. Everything works and no trouble during compiling.

Yah, that's what I've been doing all along. I only use the Arduino IDE to actually compile the code, then upload it. All the editing is done in a text editor.

I've read somewhere that one could go to "Tools | Fix Encoding & Reload" to fix compiling issues in Arduino, and I actually did that once, because of some other code that I found that would not compile.

[josemapiro]

I also have done this, just lately change the extension to. Ino, or. Pde and open the Arduino IDE, but when it does not work as intended, to distrust anything goes.
My idea when I installed Atmel studio was to check the program what happens when I press the buttons, let's see if I can by really working properly.

Thank you
José Rodrigues

[t vago]

Did you ever get your buttons to work?

[josemapiro]

Originally Posted by t vago

Did you ever get your buttons to work?

In MPGuino code never worked, but in other code works.

Thank you
José Rodrigues

[josemapiro]

I've been correcting errors that appeared in the Atmel Studio, but walking was unable to fix this ('ultoa' was not declared in this scope) have any idea what might be.

Most errors were due to pgmspace.h library here, that I use is newer and some Typedef that are in the code are deprecated in the library that use.
As you can see here: <avr/pgmspace.h>: Program Space Utilities

Thank you
José Rodrigues