If you want something small and powerful (rather than fast) Wombat is your name. They are the sort of animal that when confronted with a fence don't bother going around, over or under. Shortest route will do.
Paul, would you please commit your changes to the svn? I'm loading the software to my simple test board to work on (and test) the serial communication part and I would like to use the latest version (the one that eliminated waiting for AD conversion end).
Once I've tested (succesfully) the serial link logging I will commit my changes to the svn for your evaluation.
Dear Oprah,
Our association would like to raise the profile of Electric Vehicles and consider that a photo shoot with you draped over a vehicle clad in an electric blue bikini would ........I'm feeling faint....
The bad news is that her show is on our TVs over here, nowhere is safe!!
Being picky again, and I am sure I am stating something that has been said before. However in my opinion this
PORTB &= (128 + 64 + 32 + 16 + 8 + 4 + 1); // this sets PB1 (the pwm output) to 0 at startup. Notice '2' is missing!
Is better written as
PORTB &= 0xFD; // this clears PB1 (the pwm output) at startup.
I appreciate that hexadecimal may be unfamiliar at first, believe me if you are going to be programming regularly it is highly advisable to become familiar with HEX.
Also in programming speak you don't "set" something to "0".
An even better representation would be in binary if the compiler allows for it.
PORTB &= 0b11111101;
It gives more clarity than either the bitmask or the hex representation.
Again I agree, unfortunately Kernihan & Ritchie did not include it in their design and it has not been adopted by the ANSI standard so it is compiler dependent and not portable.
Having said that it seems that there are plenty of non standard compilers out there these days, so the thought of portability seems to have disappeared to some extent. Which is amusing as it was one of the primary considerations in the development of 'C'.
Seriously guys. Grab the code and refactor to your heart's content but let the man complete his work. None of this would have gotten off the ground if it weren't for Paul just doing it. So let's chill on the criticisms and cheer for the progress. I agree with dcb, get it done, then clean it up. The code is not that complex (though I need to have a look at the latest to see why Paul is storing the SREG as it's pushed on the stack for you during an interrupt).
To use the SVN analogy, let this tree grow before you try to prune it
Today
Other popular topics in this forum...
No "Magic Numbers" in programming.
