Go Back   EcoModder Forum > EcoModding > Fossil Fuel Free > Open ReVolt: open source DC motor controller
Register Now
 Register Now
 

Reply  Post New Thread
 
Submit Tools LinkBack Thread Tools
Old 06-08-2009, 05:47 PM   #1641 (permalink)
EcoModding Apprentice
 
Join Date: May 2009
Location: Australia
Posts: 109
Thanks: 0
Thanked 1 Time in 1 Post
Quote:
Originally Posted by JayC View Post
Seriously guys. Grab the code and refactor to your heart's content but let the man complete his work. None of this would have gotten off the ground if it weren't for Paul just doing it. So let's chill on the criticisms and cheer for the progress. I agree with dcb, get it done, then clean it up. The code is not that complex (though I need to have a look at the latest to see why Paul is storing the SREG as it's pushed on the stack for you during an interrupt).

To use the SVN analogy, let this tree grow before you try to prune it

My 2 cents.
I for one am not criticising, far from it, Paul is doing a great job.
Just sending out debatable suggestions that can be completely ignored and I will be no less happy.

  Reply With Quote
Alt Today
Popular topics

Other popular topics in this forum...

   
Old 06-08-2009, 06:00 PM   #1642 (permalink)
EcoModding Apprentice
 
Join Date: May 2009
Location: Australia
Posts: 109
Thanks: 0
Thanked 1 Time in 1 Post
Quote:
Originally Posted by charlie_fd View Post
As I recall, we have had this debate a while back in this very thread.

It has been agreed, as far as I understand, to use the pre-defined names and macros from the gcc-avr include files allowing both human readability and portability between various controllers.

The refactored code (already in the svn) is now using these extensively and custom #define for most of the application specific constants. Why are we having this conversation again?
Can you point me to the gcc-avr include files....or I could google like any other intelligent being!

Maybe I could look here http://www.nongnu.org/avr-libc/

Last edited by squiggles; 06-08-2009 at 06:08 PM.. Reason: link to avr library etc.
  Reply With Quote
Old 06-08-2009, 06:40 PM   #1643 (permalink)
PaulH
 
MPaulHolmes's Avatar
 
Join Date: Feb 2008
Location: Maricopa, AZ (sort of. Actually outside of town)
Posts: 3,832

Michael's Electric Beetle - '71 Volkswagen Superbeetle 500000
Thanks: 1,368
Thanked 1,119 Times in 734 Posts
Hello! I'm still messing up the rsvp preparation H suppository I think. I was able to commit, but it said the file was "non-versioned". I haven't seen any box that says "please enter the version", so I just sent it that way. The new file that I added to it was called "HighVoltageController 6-08-09.c" I think. I need a new control board to test stuff with it, but it doesn't use while() in most of it.

Also, I'm not sure what to download from that site (to get the little green mark on my directory), so I downloaded the trunk directory, then added the new file, and then uploaded everything back. I "committed" if you will...

Did you guys see Dark Tangent in the news today??? I knew him a little when I went to the University of Washington. We went to a "meeting" together. It was weird to see how famous he had become since then! I think he's a millionaire now too.

How do I pop the stack in C??? It's wonderful that the status register gets pushed onto the stack when I call cli(); (at least I think it does), but how do I retrieve it without assembly? stack.pop()? hehe. Anyway, too bad there's no 286, 386, 486, pentium 1, 2, 3, or 4 assembly programming necessary! Dang it! Only this dang blasted 8 bit stuff with different 3 letter words.
__________________
kits and boards
  Reply With Quote
Old 06-08-2009, 08:59 PM   #1644 (permalink)
EcoModding Lurker
 
slurryguy's Avatar
 
Join Date: Feb 2009
Location: MO
Posts: 37
Thanks: 0
Thanked 3 Times in 2 Posts
Only this dang blasted 8 bit stuff with different 3 letter words.


Haven't you added your own 4 letter words to the program yet?
  Reply With Quote
Old 06-08-2009, 10:15 PM   #1645 (permalink)
PaulH
 
MPaulHolmes's Avatar
 
Join Date: Feb 2008
Location: Maricopa, AZ (sort of. Actually outside of town)
Posts: 3,832

Michael's Electric Beetle - '71 Volkswagen Superbeetle 500000
Thanks: 1,368
Thanked 1,119 Times in 734 Posts
Slurry, you were right, I shouldn't have mentioned the golden girls in school.

I'm about 25% done converting the schematic to ExpressSCH. ExpressSCH and ExpressPCB are both free. ExpressPCB is a free gerber layout thing that companies allow you to submit instead of gerber files. Plus, there is no size limit. ya.
__________________
kits and boards
  Reply With Quote
Old 06-08-2009, 10:55 PM   #1646 (permalink)
EcoModding Apprentice
 
Join Date: May 2009
Location: Orrville, Ohio
Posts: 108
Thanks: 9
Thanked 2 Times in 2 Posts
Thumbs up

Quote:
Originally Posted by slurryguy View Post
Only this dang blasted 8 bit stuff with different 3 letter words.


Haven't you added your own 4 letter words to the program yet?
Paul, I hope your controller only says GOOD words!
Take care, Watt
  Reply With Quote
Old 06-08-2009, 11:32 PM   #1647 (permalink)
PaulH
 
MPaulHolmes's Avatar
 
Join Date: Feb 2008
Location: Maricopa, AZ (sort of. Actually outside of town)
Posts: 3,832

Michael's Electric Beetle - '71 Volkswagen Superbeetle 500000
Thanks: 1,368
Thanked 1,119 Times in 734 Posts
You guys! I mean:

xor
and
jmp
jnl
je (oops, 2 letters)
mov
cmp
jng
jge
eax
ebx
ecx
edx
esi
edi
bsr
etc...
__________________
kits and boards
  Reply With Quote
Old 06-08-2009, 11:54 PM   #1648 (permalink)
EcoModding Apprentice
 
Join Date: May 2009
Location: Orrville, Ohio
Posts: 108
Thanks: 9
Thanked 2 Times in 2 Posts
Thumbs up

Quote:
Originally Posted by MPaulHolmes View Post
You guys! I mean:

xor
and
jmp
jnl
je (oops, 2 letters)
mov
cmp
jng
jge
eax
ebx
ecx
edx
esi
edi
bsr
etc...
Works for me! Have a good night. Watt
  Reply With Quote
Old 06-09-2009, 07:14 AM   #1649 (permalink)
EcoModding Lurker
 
Join Date: May 2009
Location: Bucharest,RO and Copenhagen,DK
Posts: 42
Thanks: 0
Thanked 0 Times in 0 Posts
Quote:
Originally Posted by MPaulHolmes View Post
Hello! I'm still messing up the rsvp preparation H suppository I think.
....
Yes you are :P

Quote:
Originally Posted by MPaulHolmes View Post
I was able to commit, but it said the file was "non-versioned". I haven't seen any box that says "please enter the version", so I just sent it that way. The new file that I added to it was called "HighVoltageController 6-08-09.c" I think.
You have "deleted" a file and added another ... Here is the "changeset" of what you have committed: Changeset 14 for trunk - Open ReVolt - Trac

The idea is to work on the same file, svn will remember everything so you don't need to change the file name. When you need to add a new file to the project just use "SVN Add" before commit, which will inform the system you have placed a new file under source control. And you can commit the whole directory structure at once not necessarily each individual file.

However, you are getting better with the svn! Just work in the directory you have checked-out, and always "update" before "commit". Comment your commits so we know what the reason for commiting changes was.

I've cleaned up the svn. Your last update is now named HighVoltageController.c and there is an AVR Studio project file for it in there.

Keep up the good work! I'm running your software on a test-board, using a pot for throttle and a LED for motor. I've added a bootloader so I can quickly update the uC directly from Avr Studio using the serial link. I'm testing serial communication from within the HighVoltageController.c ...
  Reply With Quote
Old 06-09-2009, 10:06 AM   #1650 (permalink)
dcb
needs more cowbell
 
dcb's Avatar
 
Join Date: Feb 2008
Location:
Posts: 5,038

pimp mobile - '81 suzuki gs 250 t
90 day: 96.29 mpg (US)

schnitzel - '01 Volkswagen Golf TDI
90 day: 53.56 mpg (US)
Thanks: 158
Thanked 267 Times in 210 Posts
I have to say that it looks like Paul has been snookered into learning and using SVN, and I'm not real sure what purpose that serves.

Paul it wouldn't kill you to to learn about svn, but I think it would be appropriate if you just wanted to cut and paste the code into the wiki for now. I set up an example, just hit edit and replace everything between the <pre> and </pre> tags. We can lose it if you don't like it, but it means anyone can just cut that block and paste it into avrstudio.

Controller Software - EcoModder

Also, guys, changes need to be coordinated since this is basically a one file deal. So announce your intentions here, if those interested are ok then "check out" the latest version, make your changes, and "check it" back in (after a good effort at testing of course).

__________________
WINDMILLS DO NOT WORK THAT WAY!!!

Last edited by dcb; 06-09-2009 at 10:20 AM..
  Reply With Quote
Reply  Post New Thread


Thread Tools


Similar Threads
Thread Thread Starter Forum Replies Last Post
Paul and Sabrina's Cheap 3 Phase Inverter (AC Controller) with Field Oriented Control MPaulHolmes Fossil Fuel Free 3477 05-24-2021 03:28 PM
Paul & Sabrina's Cheap EV Conversion MPaulHolmes Fossil Fuel Free 542 11-12-2016 09:09 PM
Three Dirt Cheap DIY Electric Cars - Part 5 SVOboy EcoModder Blog Discussion 0 12-12-2008 04:10 PM



Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.
Content Relevant URLs by vBSEO 3.5.2
All content copyright EcoModder.com